fix: include tool descriptions in custom system prompts for code-supernova #8308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnova - Modified system prompt generation to always include tool descriptions even when using custom system prompt files - This fixes the issue where code-supernova model would fail to parse read_file tool parameters when using custom prompts - Updated tests to reflect the new behavior - Ensures models like code-supernova that require simplified tool formats get the proper tool descriptions Fixes #8307
hannesrudolph
added
the
Issue/PR - Triage
dosubot
bot
added
size:L
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| const modeConfig = getModeBySlug(mode, customModes) || modes.find((m) => m.slug === mode) || modes[0] | ||
|
|
||
| // Check if MCP functionality should be included | ||
| const hasMcpGroup = modeConfig.groups.some((groupEntry) => getGroupName(groupEntry) === "mcp") |
Contributor
Author
There was a problem hiding this comment.
P1: modeConfig.groups is accessed without a guard. A custom mode object may omit groups, causing a runtime error. Also applies to the earlier generatePrompt path.
Suggested change
| const hasMcpGroup = modeConfig.groups.some((groupEntry) => getGroupName(groupEntry) === "mcp") | |
| const hasMcpGroup = (modeConfig.groups || []).some((groupEntry) => getGroupName(groupEntry) === "mcp") |
| ${getToolUseGuidelinesSection(codeIndexManager)} | ||
| ${fileCustomSystemPrompt} |
Contributor
Author
There was a problem hiding this comment.
P2: The custom file-based prompt is appended after the Roo Tool Use sections. Consider placing the user’s custom prompt before tool/guidelines to preserve authorial context, or clarify precedence so Roo tool sections supersede overlapping instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #8307 where using custom system prompts (via
.roo/system-prompt-codefile) breaks theread_filetool for the code-supernova model.Problem
When users override the system prompt using a custom file, the tool descriptions were completely omitted from the prompt. This caused models like code-supernova (which require a simplified read_file format) to fail with errors like:
Solution
Modified the system prompt generation to always include tool descriptions even when using file-based custom prompts. This ensures that:
Changes
src/core/prompts/system.tsto include tool descriptions with custom promptsTesting
Fixes #8307
Important
Fixes issue #8307 by ensuring tool descriptions are included in custom system prompts for code-supernova, modifying
system.tsand updating tests accordingly.read_fileformat.system.tsto include tool descriptions in custom prompts.custom-system-prompt.spec.tsto test inclusion of tool descriptions.read_fileformat.This description was created by
for 1569b46. You can customize this summary. It will automatically update as commits are pushed.